Skip to content

Stop raising in read_csv when header row contains only empty cells #44657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 19, 2021

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 28, 2021

If ok with the change in general, I would suggest deprecating and changing in 2.0

@phofl phofl added Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv labels Nov 28, 2021
@jreback jreback added this to the 1.4 milestone Nov 29, 2021
@jreback
Copy link
Contributor

jreback commented Nov 29, 2021

why deprecating and not implementing the unamed case?

@jreback jreback removed this from the 1.4 milestone Nov 29, 2021
@phofl
Copy link
Member Author

phofl commented Nov 29, 2021

Was not sure if people relied on this behavior. If you think is ok to immediately stop raising, will implement that

@phofl phofl changed the title Deprecate raising in read_csv when header row contains only empty cells Stop raising in read_csv when header row contains only empty cells Dec 15, 2021
@phofl
Copy link
Member Author

phofl commented Dec 15, 2021

@jreback this immediately changes from raising to returning only Unnamed columns

@phofl phofl removed the Deprecate Functionality to remove in pandas label Dec 15, 2021
@jreback jreback added this to the 1.4 milestone Dec 19, 2021
@jreback jreback merged commit f985e58 into pandas-dev:master Dec 19, 2021
@jreback
Copy link
Contributor

jreback commented Dec 19, 2021

thanks @phofl

@phofl phofl deleted the 13054 branch December 20, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to read MultiIndex columns from CSV if empty levels
2 participants